Update dead link in extending.rst#2064
Merged
Merged
Conversation
Wifitap project maintainers website replaced with GitHub repo link.
Codecov Report
@@ Coverage Diff @@
## master #2064 +/- ##
==========================================
- Coverage 86.34% 86.33% -0.01%
==========================================
Files 197 197
Lines 44603 44603
==========================================
- Hits 38514 38510 -4
- Misses 6089 6093 +4
|
Member
|
The repo you've provided looks pretty dead :/ I'll ask there if the project is dead. If it is, it might be a better idea to remove the link |
Member
|
We are keeping that link for historical & sentimental reasons. I think we should just add a note to state that Wifitap is no longer updated... but I'd like to keep the current link. |
Do you want it to read something like this?
Contributor
Author
@p-l-, does a change like this suit? |
gpotter2
reviewed
Jun 6, 2019
Co-Authored-By: Gabriel <gabriel@potter.fr>
gpotter2
approved these changes
Jun 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve Documentation
Reading over the docs, the link to Wifitap is dead. I found Wifitap's GitHub repo and replaced the link with it.